Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): improve dependencies constraints for compatibility #11

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

EchoEllet
Copy link
Contributor

@EchoEllet EchoEllet commented Nov 3, 2024

The versions listed in pubspec.yaml indicate the minimum required for dependencies
and do not affect those used in the client's application.
For more information, visit:

The pubspec.lock should be included only for application packages, which contain the used dependencies versions.
When the client runs flutter pub get they will get the latest compatible dependencies at the time until they run flutter pub upgrade. The flutter pub upgrade --major-versions updates the major versions in pubspec.yaml.

Changes

  • Updates the package to not require Flutter SDK or Google material icons
  • Updates flutter_lints to 5.0.0 and fix analysis warnings
  • Updates minimum supported Dart SDK version From 3.4.3 to 3.0

Aditional Context

There is an analysis warning coming from unintended_html_in_doc_comment which will be enabled by default and part of the core set starting from 5.1.0. I ignored the warning to avoid additional changes.

This repo will probably need an example so contributors and CI can test against the latest dependencies (pubspec.lock included).

This PR fixes an issue on the Flutter Quill repo:

Details

Resolving dependencies...
The current Dart SDK version is 3.3.3.

Because flutter_quill >=10.6.1 depends on flutter_quill_delta_from_html >=1.1.5 which requires SDK version >=3.4.3 <4.0.0, flutter_quill >=10.6.1 is forbidden.
So, because su depends on flutter_quill 10.8.5, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on flutter_quill: flutter pub add flutter_quill:^2.0.7
exit code 1

* Updates the package to not require Flutter SDK or Google material icons
* Updates flutter_lints to 5.0.0 and fix analysis warnings
* Updates minimum supported Dart SDK version From 3.4.3 to 3.0
@CatHood0 CatHood0 merged commit 3946b12 into CatHood0:master Nov 3, 2024
@EchoEllet EchoEllet deleted the chore/compatibility branch November 4, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants